Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc/modals: FormErrorMessage that always takes up space #2379

Merged
merged 2 commits into from
Jan 26, 2023
Merged

pc/modals: FormErrorMessage that always takes up space #2379

merged 2 commits into from
Jan 26, 2023

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Jan 26, 2023 •
edited
Loading

Closes #2281

Code Changes

  • pc/modals: Use chakra isRequired instead of string asterisk
  • pc/modals: FormErrorMessage that always takes up space

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

I don't particularly love how much space is reserved, but it solves the problem. I've definitely had this UX challenge before.

Here's the cancel action:

And here's some more switching between validation:

@allisonking allisonking mentioned this pull request Jan 26, 2023
Closed
Kelsey-Ethyca
Kelsey-Ethyca approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ssangervasi ssangervasi merged commit 327a6e1 into main Jan 26, 2023
@ssangervasi ssangervasi deleted the ssangervasi/fides/2281/pc-validation-clicks branch January 26, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

@mfbrown mfbrown Awaiting requested review from mfbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User has to click twice to close the DSR request modal.
2 participants
@ssangervasi @Kelsey-Ethyca